MAINT Drop official PyPy support#29128
Merged
adrinjalali merged 7 commits intoscikit-learn:mainfrom Jun 3, 2024
Merged
Conversation
f4dae1a to
0a8d083
Compare
…nto drop-official-pypy-support
betatim
approved these changes
May 30, 2024
Member
betatim
left a comment
There was a problem hiding this comment.
I think this is a good move. We can always fish things back out of the archive to re-add pypy support (in the sense of "might work or not, fix PRs welcome") if we get contacted by people who rely on this.
adrinjalali
approved these changes
Jun 3, 2024
Member
adrinjalali
left a comment
There was a problem hiding this comment.
Looking at this PR makes me realize we REALLY don't support PyPy. So I'm very happy to not mislead people that we somewhat do.
This was referenced Jun 3, 2024
Member
|
Thank you, @lesteve. 🙏 |
This was referenced Jun 4, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed at the developer meeting.
Close #27662, close #28956.
Here is a summary of the motivations:
There is very little scikit-learn + PyPy usage
@mattip.py37hca48384_0in its filename (mamba create -n pypy scikit-learntells you this) and has been downloaded ~2000 times to be compared to the other downloads that amounts to ~3 million downloads.Maintenance has a cost
Changes in this PR
As things stand in this PR, PyPy is mentioned only in the FAQ, some old changelog,
setup.py(no need to tweak this sincesetup.pywill go away soonish), and becausesklearn.utils.IS_PYPYis deprecated and scheduled to be removed in scikit-learn 1.7: