Skip to content

🔒 🤖 CI Update lock files for pypy CI build(s) 🔒 🤖#28869

Closed
scikit-learn-bot wants to merge 1 commit intoscikit-learn:mainfrom
scikit-learn-bot:auto-update-lock-files-pypy
Closed

🔒 🤖 CI Update lock files for pypy CI build(s) 🔒 🤖#28869
scikit-learn-bot wants to merge 1 commit intoscikit-learn:mainfrom
scikit-learn-bot:auto-update-lock-files-pypy

Conversation

@scikit-learn-bot
Copy link
Copy Markdown
Contributor

Update lock files.

Note

If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.

@scikit-learn-bot scikit-learn-bot force-pushed the auto-update-lock-files-pypy branch from 5166ff4 to 11e5ae9 Compare April 22, 2024 05:02
@github-actions
Copy link
Copy Markdown

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 11e5ae9. Link to the linter CI: here

@ogrisel
Copy link
Copy Markdown
Member

ogrisel commented Apr 22, 2024

This fails when running test_import_all_consistency (sklearn/tests/test_common.py:230) when importing the Cython module sklearn.datasets._svmlight_format_fast:

ValueError: array.array size changed, may indicate binary incompatibility. Expected 72 from C header, got 24 from PyObject

This seems to be a real regression because the scheduled PyPy tests ran successfully last night on main:

https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=65968&view=logs&j=0b16f832-29d6-5b92-1c23-eb006f606a66&t=0cdfadab-878f-502c-9df1-54a896e98c4f

@ogrisel
Copy link
Copy Markdown
Member

ogrisel commented Apr 22, 2024

According to this message pyproj4/pyproj#854 (comment) it seems that using array.array in Cython (with PyPy in particular) is inherently problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants