FEA Callbacks base infrastructure + progress bars#28760
FEA Callbacks base infrastructure + progress bars#28760jeremiedbb merged 129 commits intoscikit-learn:callbacksfrom
Conversation
|
Reviewing this PR has gotten a bit harder since upstream commits were merged into it (but not into the |
|
I just forgot tu push the callback branch :) the diff should be good now |
| # about the task being executed and its position in the task tree. | ||
|
|
||
|
|
||
| class CallbackContext: |
There was a problem hiding this comment.
Can we have a __str__ or __repr__ for CallbackContext that shows the estimator_name, its task_id, and maybe get_context_path(self)?
For the moment its just something like <sklearn.callback._callback_context.CallbackContext object at 0x7f2b94733b30>.
ogrisel
left a comment
There was a problem hiding this comment.
The discussion of this PR is becoming too large for github.
I think we can merge this PR to the feature branch and create dedicated issues for each unresolved comments. This will allow having concurrent discussion threads in smaller/more focused issues and PRs.
StefanieSenger
left a comment
There was a problem hiding this comment.
Happy to approve, so this can be merged into the callbacks feature branch and opened as a PR towards main. 🎉
|
Thanks everyone for the reviews. Very happy that we can merge this PR (in a feature branch but still 😄 ) ! |
Alternative to #27663 based on feedback from the drafting meeting. I'm keeping both open for now for easier comparison.