Skip to content

DOC linked isotonic regression example to isotonic regression doc#28673

Merged
ArturoAmorQ merged 3 commits intoscikit-learn:mainfrom
Dev-Akash:isotonicRegression
Mar 25, 2024
Merged

DOC linked isotonic regression example to isotonic regression doc#28673
ArturoAmorQ merged 3 commits intoscikit-learn:mainfrom
Dev-Akash:isotonicRegression

Conversation

@Dev-Akash
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Issue #26927

What does this implement/fix? Explain your changes.

This PR add link in doc/Module/Isotonic for example of isotonic regression - miscellaneous/plot_isotonic_regression.py

Any other comments?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 21, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: e328660. Link to the linter CI: here

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please consider the comment/suggestion below:

Added suggested changes

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@Dev-Akash
Copy link
Copy Markdown
Contributor Author

Hi @ogrisel,
Thanks for suggesting a better change. I have added those changes.
Please review and consider the PR.
Thank you!

Copy link
Copy Markdown
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Dev-Akash, LGTM as it is. Merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants