DOC Linked examples for LDA and QDA in their docstrings (#26927)#28611
Merged
glemaitre merged 5 commits intoscikit-learn:mainfrom Mar 14, 2024
Merged
DOC Linked examples for LDA and QDA in their docstrings (#26927)#28611glemaitre merged 5 commits intoscikit-learn:mainfrom
glemaitre merged 5 commits intoscikit-learn:mainfrom
Conversation
betatim
reviewed
Mar 11, 2024
sklearn/discriminant_analysis.py
Outdated
| This should be left to None if `covariance_estimator` is used. | ||
| Note that shrinkage works only with 'lsqr' and 'eigen' solvers. | ||
|
|
||
| For an example usage, see |
Member
There was a problem hiding this comment.
Suggested change
| For an example usage, see | |
| For a usage example, see |
I'd rewrite this like this
betatim
reviewed
Mar 11, 2024
sklearn/discriminant_analysis.py
Outdated
| min(n_classes - 1, n_features). This parameter only affects the | ||
| `transform` method. | ||
|
|
||
| For an example usage for dimensionality reduction, see |
Member
There was a problem hiding this comment.
Suggested change
| For an example usage for dimensionality reduction, see | |
| For a usage example, see |
I'd rewrite this like this
betatim
reviewed
Mar 11, 2024
Member
betatim
left a comment
There was a problem hiding this comment.
Thanks for helping make the examples easier to find!
Looks good to me, besides the two suggestions I made.
Contributor
Author
|
Thank you for the feedback. I've made the updates. |
glemaitre
approved these changes
Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Adds links to examples/classification mentioned in #26927
What does this implement/fix? Explain your changes.
Adds links to auto-generated examples for classes
LinearDiscriminantAnalysisandQuadraticDiscriminantAnalysisAny other comments?
Examples linked:
examples/classificationplot_lda.pyplot_lda_qda.pyexamples/decompositionplot_pca_vs_lda.py