ENH Select arpack for sparse inputs and do not raise error#28498
Merged
glemaitre merged 21 commits intoscikit-learn:mainfrom Feb 29, 2024
Merged
ENH Select arpack for sparse inputs and do not raise error#28498glemaitre merged 21 commits intoscikit-learn:mainfrom
glemaitre merged 21 commits intoscikit-learn:mainfrom
Conversation
glemaitre
reviewed
Feb 22, 2024
Member
glemaitre
left a comment
There was a problem hiding this comment.
Here are a couple of comments.
Contributor
There was a problem hiding this comment.
Thanks for the PR @lamdang2k! Sorry for the confusion my wording may have caused you in the original issue. Here are some minor comments.
Contributor
|
The decomposition module heading in the changelog seems to be misplaced. |
glemaitre
reviewed
Feb 28, 2024
Charlie-XIAO
approved these changes
Feb 28, 2024
Contributor
Charlie-XIAO
left a comment
There was a problem hiding this comment.
LGTM, thanks @lamdang2k!
glemaitre
approved these changes
Feb 29, 2024
Member
glemaitre
left a comment
There was a problem hiding this comment.
LGTM. Thanks @lamdang2k
I remove a couple of comments that were present in the code while it was already self explicit by reading the code.
Member
|
Enabling auto-merge. Thanks @lamdang2k |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #28406
What does this implement/fix? Explain your changes.
arpacksolver when the input is sparsearpacksolver has been chosenAny other comments?