DOC Use effective value for max_iter in BayesianRidge and ARDRegression#28476
Merged
jeremiedbb merged 1 commit intoscikit-learn:mainfrom Feb 20, 2024
Merged
DOC Use effective value for max_iter in BayesianRidge and ARDRegression#28476jeremiedbb merged 1 commit intoscikit-learn:mainfrom
max_iter in BayesianRidge and ARDRegression#28476jeremiedbb merged 1 commit intoscikit-learn:mainfrom
Conversation
max_iter in docstringmax_iter in BayesianRidge and ARDRegression
betatim
approved these changes
Feb 20, 2024
Member
betatim
left a comment
There was a problem hiding this comment.
Fine for me. Let's see if someone else has opinions (that go the other way)
jeremiedbb
approved these changes
Feb 20, 2024
Member
jeremiedbb
left a comment
There was a problem hiding this comment.
LGTM since None is just there for the duration of the deprecation of n_iter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Noticed in: #28471 (comment)
What does this implement/fix? Explain your changes.
Use effective value for
max_iter, instead ofNonethen explaining thatNoneeffectively means 300. This is done elsewhere #28471 (comment)Any other comments?
cc @betatim