DOC Remove old docstring notes from sklearn/feature_extraction/image.py#28468
Merged
betatim merged 1 commit intoscikit-learn:mainfrom Feb 20, 2024
Conversation
Charlie-XIAO
approved these changes
Feb 20, 2024
Contributor
Charlie-XIAO
left a comment
There was a problem hiding this comment.
LGTM, thanks for the cleanup @ChVeen!
betatim
approved these changes
Feb 20, 2024
Member
|
Thank you for tidying up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes issue #28454
What does this implement/fix? Explain your changes.
This PR removes too old notes which are contained in two docstrings at
https://github.com/scikit-learn/scikit-learn/blob/main/sklearn/feature_extraction/image.py#L178-L185
and
https://github.com/scikit-learn/scikit-learn/blob/main/sklearn/feature_extraction/image.py#L232-L239
as discussed in issue ##28454.
Any other comments?