Skip to content

MAINT adding Yao Xiao in the core contributor#28463

Merged
adrinjalali merged 1 commit intoscikit-learn:mainfrom
glemaitre:adding_yao_xiao
Feb 19, 2024
Merged

MAINT adding Yao Xiao in the core contributor#28463
adrinjalali merged 1 commit intoscikit-learn:mainfrom
glemaitre:adding_yao_xiao

Conversation

@glemaitre
Copy link
Copy Markdown
Member

Follow-up of the announcement of adding @Charlie-XIAO as a core contributor.

@Charlie-XIAO I added you the maintainer team and as well to the documentation one to acknowledge the work to redesign of the webpage with the switch to pydata-sphinx-theme.

I checked the rendering and everything looked OK locally.

<div>
<a href='https://github.com/francoisgoupil'><img src='https://avatars.githubusercontent.com/u/98105626?v=4' class='avatar' /></a> <br />
<p>francoisgoupil</p>
<p>François Goupil</p>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that Francois changed is name linked to his profile. It should be fine to update it at the same time.

@github-actions
Copy link
Copy Markdown

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: c28dfbb. Link to the linter CI: here

@Charlie-XIAO
Copy link
Copy Markdown
Contributor

Charlie-XIAO commented Feb 19, 2024

Thanks @glemaitre! Looking forward to working with team 😁

Copy link
Copy Markdown
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrinjalali
Copy link
Copy Markdown
Member

I'll let you merge main with the new website branch on the main repo from now on @Charlie-XIAO 😉

@adrinjalali adrinjalali merged commit 5eee413 into scikit-learn:main Feb 19, 2024
@Charlie-XIAO
Copy link
Copy Markdown
Contributor

Sure, thanks for your help all this time @adrinjalali!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants