Skip to content

🔒 🤖 CI Update lock files for main CI build(s) 🔒 🤖#28461

Merged
ogrisel merged 2 commits intoscikit-learn:mainfrom
scikit-learn-bot:auto-update-lock-files-main
Feb 26, 2024
Merged

🔒 🤖 CI Update lock files for main CI build(s) 🔒 🤖#28461
ogrisel merged 2 commits intoscikit-learn:mainfrom
scikit-learn-bot:auto-update-lock-files-main

Conversation

@scikit-learn-bot
Copy link
Copy Markdown
Contributor

@scikit-learn-bot scikit-learn-bot commented Feb 19, 2024

Update lock files.

Note

If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.

@scikit-learn-bot scikit-learn-bot force-pushed the auto-update-lock-files-main branch from b190ed2 to 09f8632 Compare February 19, 2024 05:07
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 19, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: f9848e4. Link to the linter CI: here

@ogrisel ogrisel mentioned this pull request Feb 19, 2024
Closed
@ogrisel
Copy link
Copy Markdown
Member

ogrisel commented Feb 19, 2024 •
edited
Loading

We have similar failures both in pylatest_pip_openblas_pandas and ubuntu_atlas:

FAILED datasets/tests/test_lfw.py::test_load_fake_lfw_people - OSError: /home/vsts/scikit_learn_data/lfw_home/pairsDevTrain.txt is missing
FAILED datasets/tests/test_lfw.py::test_load_fake_lfw_people_too_restrictive - OSError: /home/vsts/scikit_learn_data/lfw_home/pairsDevTrain.txt is missing
FAILED datasets/tests/test_lfw.py::test_load_fake_lfw_pairs - OSError: /home/vsts/scikit_learn_data/lfw_home/pairsDevTrain.txt is missing
FAILED datasets/tests/test_lfw.py::test_fetch_lfw_people_internal_cropping - OSError: /home/vsts/scikit_learn_data/lfw_home/pairsDevTrain.txt is missing
FAILED metrics/tests/test_score_objects.py::test_scorer_memmap_input[accuracy] - TypeError: 'NoneType' object is not subscriptable
FAILED metrics/tests/test_score_objects.py::test_scorer_memmap_input[adjusted_mutual_info_score] - TypeError: 'NoneType' object is not subscriptable
FAILED metrics/tests/test_score_objects.py::test_scorer_memmap_input[adjusted_rand_score] - TypeError: 'NoneType' object is not subscriptable
FAILED metrics/tests/test_score_objects.py::test_scorer_memmap_input[average_precision] - TypeError: 'NoneType' object is not subscriptable
FAILED metrics/tests/test_score_objects.py::test_scorer_memmap_input[balanced_accuracy] - TypeError: 'NoneType' object is not subscriptable
FAILED metrics/tests/test_score_objects.py::test_scorer_memmap_input[completeness_score] - TypeError: 'NoneType' object is not subscriptable

We also get similar issues on scipy-dev (in #28459).

The CI builds where most of the dependencies are downloaded from conda-forge do not seem to fail so this must be caused by a package downloaded from pypi.org.

The test_scorer_memmap_input failure seems to imply that ESTIMATORS is left to None which can happen if setup_module is not called before running the test.

By glancing at the diff for pylatest_pip_openblas_pandas https://github.com/scikit-learn/scikit-learn/pull/28461/files#diff-973ad551db7289e64da8bae4474bbb929cb0b5a5d81aa4b49d6a578ee15eb599 we see that pytest 8.0.0 is bumped to 8.0.1 so maybe it's related?

@lesteve
Copy link
Copy Markdown
Member

lesteve commented Feb 19, 2024

Seems to be Pytest 8.0.1 indeed, Ubuntu Atlas build fails and this is the only thing that gets updated: https://github.com/scikit-learn/scikit-learn/pull/28461/files#diff-b4652ddeb4d671bf8cae97fb9c5db65d7f602ddae6b54f0bdcad2a99e5459690

@ogrisel
Copy link
Copy Markdown
Member

ogrisel commented Feb 19, 2024

And the scipy-dev build also fails with 8.0.1 while all other builds that are green in this PR stayed on older versions of pytest <= 8.0.0 (from conda-forge, conda defaults or pypi.org with a min dependency constraint).

@lesteve lesteve mentioned this pull request Feb 19, 2024
Closed
@lesteve
Copy link
Copy Markdown
Member

lesteve commented Feb 19, 2024

Looks like setup_module is not being run with --doctest-modules in pytest 8.0.1, I opened pytest-dev/pytest#12011.

@lesteve lesteve mentioned this pull request Feb 20, 2024
Merged
@lesteve
Copy link
Copy Markdown
Member

lesteve commented Feb 20, 2024

I opened #28475 to replace the two instances of setup_module by Pytest fixtures, this would avoid the pytest 8.0.1 bug.

@scikit-learn-bot scikit-learn-bot force-pushed the auto-update-lock-files-main branch from 09f8632 to 98c6f18 Compare February 26, 2024 05:07
@ogrisel ogrisel enabled auto-merge (squash) February 26, 2024 15:48
ogrisel
ogrisel approved these changes Feb 26, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this if CI is green after a merge with main that has been fixed.

@ogrisel ogrisel merged commit 3ce527d into scikit-learn:main Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees

No one assigned

Labels

Build / CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@scikit-learn-bot @ogrisel @lesteve @web-flow