DOC fix jupyterlab and binder could not find polars#28457
Merged
adrinjalali merged 2 commits intoscikit-learn:mainfrom Feb 19, 2024
Merged
DOC fix jupyterlab and binder could not find polars#28457adrinjalali merged 2 commits intoscikit-learn:mainfrom
polars#28457adrinjalali merged 2 commits intoscikit-learn:mainfrom
Conversation
betatim
approved these changes
Feb 19, 2024
Member
betatim
left a comment
There was a problem hiding this comment.
Thanks for this!
I remember there is some cleverness around when the image is built for mybinder.org. So I wonder if we need to do something on top of merging this to make it work for the existing v1.4 documentation?
adrinjalali
approved these changes
Feb 19, 2024
Member
|
We could backport this to 1.4 branch. cc @glemaitre |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example
plot_release_highlights_1_4_0importspolarsbut we do not add that to binder and jupyterlab.