ENH minor improvement of binomial hessian#28453
Merged
jeremiedbb merged 1 commit intoscikit-learn:mainfrom Feb 20, 2024
Merged
Conversation
OmarManzoor
reviewed
Feb 19, 2024
OmarManzoor
approved these changes
Feb 19, 2024
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @lorentzenchr
jeremiedbb
approved these changes
Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#28048
What does this implement/fix? Explain your changes.
First, the formula for the hessian is wrong, but the difference is beyond machine precision.
For
raw_prediction <= -37,exp(raw_prediction) <= 8.533047625744066e-17is tiny.Correct formula:
hessian = exp(raw_prediction) / (1 + exp(raw_prediction))**22nd order hessian:
hessian = exp(raw_prediction) * (1 - 2 * exp(raw_prediction))1st order hessian:
hessian = exp(raw_prediction)The 2nd order hessian is wrongly implemented without the factor 2.
Any other comments?