MNT update get_equivalent_estimator for HGBT#28449
Merged
jeremiedbb merged 1 commit intoscikit-learn:mainfrom Feb 20, 2024
Merged
MNT update get_equivalent_estimator for HGBT#28449jeremiedbb merged 1 commit intoscikit-learn:mainfrom
jeremiedbb merged 1 commit intoscikit-learn:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
None
What does this implement/fix? Explain your changes.
This updates the
get_equivalent_estimatorutility function, that produces equivalent estimators of LightGBM and XGBoost for our HistGradientBoosting* estimators.Any other comments?
It is kind of strange that this functions lives in Cython as it is pure Python and no performance needed.