DOC Correct PCA documentation about sparse input#28416
Merged
glemaitre merged 6 commits intoscikit-learn:mainfrom Feb 19, 2024
Merged
DOC Correct PCA documentation about sparse input#28416glemaitre merged 6 commits intoscikit-learn:mainfrom
glemaitre merged 6 commits intoscikit-learn:mainfrom
Conversation
glemaitre
reviewed
Feb 14, 2024
sklearn/decomposition/_pca.py
Outdated
Comment on lines
+133
to
+137
| It can also use the scipy.sparse.linalg ARPACK implementation of the | ||
| truncated SVD. | ||
|
|
||
| Notice that this class does not support sparse input. See | ||
| :class:`TruncatedSVD` for an alternative with sparse data. | ||
| This class now supports `scipy.sparse.sparray` and `scipy.sparse.spmatrix` | ||
| inputs when using the ARPACK solver. |
Member
There was a problem hiding this comment.
I would merge this part with the paragraph above:
With sparse inputs, the ARPACK implementation of the truncated SVD can be
used through :func:`scipy.sparse.linalg.svds`. Alternatively, one may
considered :class:`TruncatedSVD` where the data are not centered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Correct #28406
What does this implement/fix? Explain your changes.
Adapt documentation to changes coming from release note 1.4: PCA now supports sparse input
Any other comments?