DOC: Added drop down menus to 6.3 Preprocessing Data#27922
Merged
ArturoAmorQ merged 23 commits intoscikit-learn:mainfrom Feb 16, 2024
Merged
DOC: Added drop down menus to 6.3 Preprocessing Data#27922ArturoAmorQ merged 23 commits intoscikit-learn:mainfrom
6.3 Preprocessing Data#27922ArturoAmorQ merged 23 commits intoscikit-learn:mainfrom
Conversation
54 tasks
ArturoAmorQ
reviewed
Feb 13, 2024
Member
ArturoAmorQ
left a comment
There was a problem hiding this comment.
Additional to the comments below, you can use dropdown to hide:
- The Yeo-Johnson and Box-Cox transforms (as two separete dropdowns) in 6.3.2.2. Mapping to a Gaussian distribution. Keep the paragraph saying "Below are examples of Box-Cox and Yeo-Johnson applied to various probability distributions [...]" and the example image out of the dropdown.
- The
Sparse inputparagraph in 6.3.3. Normalization - Create a dropdown for the paragraphs on
Support of categorical features with missing valuesjust above 6.3.4.1. Infrequent categories - Create 3 dropdowns inside the 6.3.4.2. Target Encoder section: For the binary classification target, the multiclass target and continuous targets.
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
ArturoAmorQ
reviewed
Feb 14, 2024
Member
ArturoAmorQ
left a comment
There was a problem hiding this comment.
We are almost there! Here's another batch of comments.
Also, for creating the binary classification target dropdown in section 6.3.4.2. Target Encoder you can split the paragraph in current line 907, i.e. starting from "For the binary classification target, the target encoding is given by: [...]"
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
ArturoAmorQ
approved these changes
Feb 15, 2024
Member
ArturoAmorQ
left a comment
There was a problem hiding this comment.
Just a couple of suggestions, but otherwise it LGTM :)
Comment on lines
+222
to
+230
| |details-start| | ||
| **References** | ||
| |details-split| | ||
|
|
||
| Further discussion on the importance of centering and scaling data is | ||
| available on this FAQ: `Should I normalize/standardize/rescale the data? | ||
| <http://www.faqs.org/faqs/ai-faq/neural-nets/part2/section-16.html>`_ | ||
|
|
||
| |details-end| |
Member
There was a problem hiding this comment.
Can you please move this dropdown right after the Scaling vs. Whitening topic? Just an aesthetic tweak.
Optionally, you can also hide said topic inside a dropdown.
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
ArturoAmorQ
reviewed
Feb 16, 2024
ArturoAmorQ
reviewed
Feb 16, 2024
ArturoAmorQ
reviewed
Feb 16, 2024
ArturoAmorQ
reviewed
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #26617
What does this implement/fix? Explain your changes.
This adds drop down menus for all references.