Skip to content

DOC: Added drop down menus to 6.3 Preprocessing Data#27922

Merged
ArturoAmorQ merged 23 commits intoscikit-learn:mainfrom
linus-md:preprocessing-docs
Feb 16, 2024
Merged

DOC: Added drop down menus to 6.3 Preprocessing Data#27922
ArturoAmorQ merged 23 commits intoscikit-learn:mainfrom
linus-md:preprocessing-docs

Conversation

@linus-md
Copy link
Copy Markdown
Contributor

@linus-md linus-md commented Dec 8, 2023

Reference Issues/PRs

Addresses #26617

What does this implement/fix? Explain your changes.

This adds drop down menus for all references.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 8, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 6009880. Link to the linter CI: here

Copy link
Copy Markdown
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional to the comments below, you can use dropdown to hide:

  • The Yeo-Johnson and Box-Cox transforms (as two separete dropdowns) in 6.3.2.2. Mapping to a Gaussian distribution. Keep the paragraph saying "Below are examples of Box-Cox and Yeo-Johnson applied to various probability distributions [...]" and the example image out of the dropdown.
  • The Sparse input paragraph in 6.3.3. Normalization
  • Create a dropdown for the paragraphs on Support of categorical features with missing values just above 6.3.4.1. Infrequent categories
  • Create 3 dropdowns inside the 6.3.4.2. Target Encoder section: For the binary classification target, the multiclass target and continuous targets.

@linus-md linus-md requested a review from ArturoAmorQ February 13, 2024 18:51
Copy link
Copy Markdown
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are almost there! Here's another batch of comments.

Also, for creating the binary classification target dropdown in section 6.3.4.2. Target Encoder you can split the paragraph in current line 907, i.e. starting from "For the binary classification target, the target encoding is given by: [...]"

linus-md and others added 6 commits February 14, 2024 18:28
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Copy link
Copy Markdown
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of suggestions, but otherwise it LGTM :)

Comment on lines +222 to +230
|details-start|
**References**
|details-split|

Further discussion on the importance of centering and scaling data is
available on this FAQ: `Should I normalize/standardize/rescale the data?
<http://www.faqs.org/faqs/ai-faq/neural-nets/part2/section-16.html>`_

|details-end|
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please move this dropdown right after the Scaling vs. Whitening topic? Just an aesthetic tweak.

Optionally, you can also hide said topic inside a dropdown.

Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
@ArturoAmorQ ArturoAmorQ enabled auto-merge (squash) February 16, 2024 10:18
@ArturoAmorQ ArturoAmorQ merged commit e2ebce4 into scikit-learn:main Feb 16, 2024
@linus-md linus-md deleted the preprocessing-docs branch February 16, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants