DOC: Added drop down menus to 1.6 Nearest Neighbors#27919
Merged
ArturoAmorQ merged 23 commits intoscikit-learn:mainfrom Feb 14, 2024
Merged
DOC: Added drop down menus to 1.6 Nearest Neighbors#27919ArturoAmorQ merged 23 commits intoscikit-learn:mainfrom
1.6 Nearest Neighbors#27919ArturoAmorQ merged 23 commits intoscikit-learn:mainfrom
Conversation
This reverts commit cbfdf5d.
1.61.6 Nearest Neighbors
54 tasks
ArturoAmorQ
reviewed
Feb 13, 2024
Member
ArturoAmorQ
left a comment
There was a problem hiding this comment.
Apart from the comment below, you can also use dropdowns to hide:
doc/modules/neighbors.rst
Outdated
Comment on lines
+847
to
+852
| |details-start| | ||
|
|
||
| .. topic:: References: | ||
|
|
||
| |details-split| | ||
|
|
Member
There was a problem hiding this comment.
This dropdown contains a reference from it's exterior. The other ones can stay but this one we'll have to revert it please.
ArturoAmorQ
reviewed
Feb 13, 2024
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
ArturoAmorQ
reviewed
Feb 14, 2024
Member
ArturoAmorQ
left a comment
There was a problem hiding this comment.
Another pass of comments. This PR is looking in good shape!
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
ArturoAmorQ
approved these changes
Feb 14, 2024
Member
ArturoAmorQ
left a comment
There was a problem hiding this comment.
Don't mind me, just pushing some tweaks. Otherwise LGTM, merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #26617
What does this implement/fix? Explain your changes.
This adds drop down menus for all references.