Skip to content

DOC: Added drop down menus to 1.11 Ensemble Methods#27915

Merged
ArturoAmorQ merged 13 commits intoscikit-learn:mainfrom
linus-md:ensemble-doc
Feb 16, 2024
Merged

DOC: Added drop down menus to 1.11 Ensemble Methods#27915
ArturoAmorQ merged 13 commits intoscikit-learn:mainfrom
linus-md:ensemble-doc

Conversation

@linus-md
Copy link
Copy Markdown
Contributor

@linus-md linus-md commented Dec 8, 2023

Reference Issues/PRs

Addresses #26617.

What does this implement/fix? Explain your changes.

This adds drop down menus for all references.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 8, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 2700111. Link to the linter CI: here

@linus-md linus-md changed the title DOC: Added drop down menus to 1.11 DOC: Added drop down menus to 1.11 Ensemble Methods Dec 8, 2023
@linus-md
Copy link
Copy Markdown
Contributor Author

Hi @ArturoAmorQ do you have any feedback on this?

@ArturoAmorQ
Copy link
Copy Markdown
Member

Hi @linus-md as always thanks for your PRs and sorry for not giving feedback on this one before. Unfortunately the current implementation of dropdowns breaks the sphinx cross-reference system whenever they point inside a dropdown from the outside. The underlying issue is that the dropdown has to be unfolded for mozilla to access the reference.

In this case you will have to revert all of the references you are hiding in a dropdown (again, sorry about that). You can still use dropdowns to hide:

Copy link
Copy Markdown
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushing some commits and merging, thanks again for your work @linus-md!

@ArturoAmorQ ArturoAmorQ enabled auto-merge (squash) February 16, 2024 10:37
@ArturoAmorQ ArturoAmorQ merged commit 7a68c9b into scikit-learn:main Feb 16, 2024
@linus-md linus-md deleted the ensemble-doc branch February 16, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants