Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/datasets/tests/test_openml.py#27323

Closed
alxfgh wants to merge 5 commits intoscikit-learn:mainfrom
alxfgh:Sparse_Tests_OpenML
Closed

TST Extend tests for scipy.sparse.*array in sklearn/datasets/tests/test_openml.py#27323
alxfgh wants to merge 5 commits intoscikit-learn:mainfrom
alxfgh:Sparse_Tests_OpenML

Conversation

@alxfgh
Copy link
Copy Markdown
Contributor

@alxfgh alxfgh commented Sep 9, 2023

Reference Issues/PRs

Towards #27090

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 9, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 0d99787. Link to the linter CI: here

@glemaitre
Copy link
Copy Markdown
Member

As in the previous PR, I merged main into the branch, and run pre-commit.
I also launch the scipy-dev to check of any unexpected failures.

@glemaitre
Copy link
Copy Markdown
Member

Actually, here we don't need to change anything because we are not storing/creating the dataset. So it will always be a scipy.sparse.csr_matrix irrespective of the scipy version.

Closing. Thanks @alxfgh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants