FEA Introduce PairwiseDistances, a generic back-end for pairwise_distances#26983
Open
Micky774 wants to merge 46 commits intoscikit-learn:mainfrom
Open
FEA Introduce PairwiseDistances, a generic back-end for pairwise_distances#26983Micky774 wants to merge 46 commits intoscikit-learn:mainfrom
PairwiseDistances, a generic back-end for pairwise_distances#26983Micky774 wants to merge 46 commits intoscikit-learn:mainfrom
Conversation
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
This allows using older versions of threadpoolctl.
Contributor
Author
|
@jjerphan @Vincent-Maladiere When developing this, had either of you investigated the viability of parallelizing |
Member
|
I do not think that we have tried. |
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #23958
Supersedes #25561
What does this implement/fix? Explain your changes.
From #25561:
This simplifies the original implementation of
PairwiseDistanceby @jjerphan, with the following differences:PairwiseDistance{32,64}doesn't subclassBaseDistancesReduction{32,64}anymore._parallel_on_{X,Y}methods toPairwiseDistance{32,64}, since these methods are decorated with@finalinBaseBaseDistancesReduction{32,64}and thus can't be overwritten.chunk_size = 1, as proposed by @ogrisel in this comment.This PR:
PairwiseDistancespairwise_distancesn_jobsparameter toPairwiseDistancesto preserven_jobssemantics frompairwise_distancesX_is_Yattribute toPairwiseDistancesto minimize change to unrelated API (all that would be affected byDatasetsPair)Any other comments?
Benchmarks will be coming soon