Skip to content

add link to example cluster_iris#26974

Closed
tiaversa wants to merge 1 commit intoscikit-learn:mainfrom
tiaversa:main
Closed

add link to example cluster_iris#26974
tiaversa wants to merge 1 commit intoscikit-learn:mainfrom
tiaversa:main

Conversation

@tiaversa
Copy link
Copy Markdown

@tiaversa tiaversa commented Aug 1, 2023

Reference Issues/PRs

This merge request is to add a link to an example into the plot_cluster_iris.py file.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 1, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: d37105c. Link to the linter CI: here

@StefanieSenger
Copy link
Copy Markdown
Member

Hey @tiaversa, thanks for your contribution. The examples are meant to be linked in the docstrings of the estimators, so it's easier to find them from where the users are first looking for information.
Instead of what you tried, you should find somewhere in sklearn/cluster/_kmeans.py, where this link makes sense. Maybe at where the k param is described.

@marenwestermann
Copy link
Copy Markdown
Member

Hi @tiaversa, do yo plan to continue working on this? If yes, do you need help?

@tiaversa
Copy link
Copy Markdown
Author

Hello @marenwestermann, thank you for bringing this to my attention, I should have said something earlier. I won't be able to take care of this issue. Please feel free to do it if you would like or direct it to someone else who is available to do so. I'm so very sorry for that.

@marenwestermann
Copy link
Copy Markdown
Member

No worries, that's ok. I will take over then. If you would like to work on something else in the future and need support, let me know. 😊

@adrinjalali
Copy link
Copy Markdown
Member

Closing this for now then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants