Added example to sklearn.svm.NuSVC#26972
Closed
TheCheshireCat6 wants to merge 5 commits intoscikit-learn:mainfrom
Closed
Added example to sklearn.svm.NuSVC#26972TheCheshireCat6 wants to merge 5 commits intoscikit-learn:mainfrom
TheCheshireCat6 wants to merge 5 commits intoscikit-learn:mainfrom
Conversation
adrinjalali
reviewed
Aug 3, 2023
Comment on lines
+1090
to
+1091
| See :ref:`sphx_glr_auto_examples_svm_plot_svm_nonlinear.py` | ||
| for a more detailed example. |
Member
There was a problem hiding this comment.
I think plot_svm_nonlinear.py could also be removed, we have the other example that @StefanieSenger is working on which nicely includes non linear kernels. WDYT @glemaitre
Member
There was a problem hiding this comment.
It is true. Here, this is the typical XOR example. We should probably have this example for all classifiers but not specifically for the SVM.
Member
|
Thanks for the PR, but we've decided to remove this example and it's done in #27108 |
Member
|
I'm closing this PR. Thank you @TheCheshireCat6 for your work. If you like you could submit another PR that contributes to the same meta-issue as this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #26927
Added example plot_svm_nonlinear.py to sklearn.svm.NuSVC
@adrinjalali @glemaitre