DOC linked SplineTransformer to time-related feature engineering example#26971
DOC linked SplineTransformer to time-related feature engineering example#26971glemaitre merged 3 commits intoscikit-learn:mainfrom scaja:my_whatever
Conversation
| In order to learn more about the SplineTransformer class go to: | ||
| :ref:`sphx_glr_auto_examples_applications_plot_cyclical_feature_engineering.py` |
There was a problem hiding this comment.
This is a good example, and could be mentioned in more places since it's more on the realistic side of things.
I'd suggest having a link in ColumnTransformer, Pipeline, and TimeSeriesSplit as well.
But the description could be more informative. Something like:
Fore a more comprehensive example on a time series data est, see ...
WDYT @glemaitre
There was a problem hiding this comment.
Definitely for TimeSeriesSplit. For ColumnTransformer and Pipeline, let's do it as well. We have to be careful in the future that for those two, we don't have too many examples.
|
I'm new here and figuring out some things.......Is this issue still open? Is anybody working on this? |
|
@manthanindane The corresponding issue is still open here: #26927 |
ogrisel
left a comment
There was a problem hiding this comment.
+1 for merging this PR as such as it's already a net improvement.
|
Added the link for TimeSeriesSplit, leaving the other ones alone. Feel free to merge @ogrisel or @glemaitre |
|
How do we figure out which example file reference to be added in which file? |
|
@Ujjwal29 it's either in the docstrings of related classes (inside the |
Reference Issues/PRs
issue #26927
What does this implement/fix? Explain your changes.
This PR linked SplineTransformer to time-related feature engineering example
Related Example files:
plot_cyclical_feature_engineering.py