DOC Add link to plot_tree_regression.py example#26962
Merged
adrinjalali merged 5 commits intoscikit-learn:mainfrom Oct 18, 2024
Merged
DOC Add link to plot_tree_regression.py example#26962adrinjalali merged 5 commits intoscikit-learn:mainfrom
adrinjalali merged 5 commits intoscikit-learn:mainfrom
Conversation
Member
|
I think |
Member
|
I've merged the two examples here. WDYT @marenwestermann @glemaitre |
glemaitre
approved these changes
Oct 17, 2024
| `max_depth` parameter) is set too high, the decision trees learn too fine | ||
| details of the training data and learn from the noise, i.e. they overfit. | ||
| ======================== | ||
| """ |
Member
There was a problem hiding this comment.
I would still write a small intro of what we will see
| # `max_depth` parameter) is set too high, the decision trees learn too fine | ||
| # details of the training data and learn from the noise, i.e. they overfit. | ||
| # | ||
| # Necessary Imports |
Member
There was a problem hiding this comment.
Let's delay the import in the cell that we use them.
glemaitre
approved these changes
Oct 17, 2024
Member
glemaitre
left a comment
There was a problem hiding this comment.
It looks good. I would not propose any further improvement. I think that we could revisit this example in another PR with this intent.
marenwestermann
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This pr adds link in DecisionTreeRegressor to example file
tree/plot_tree_regression.pyas mentioned in #26927What does this implement/fix? Explain your changes.
Any other comments?