Skip to content

DOC Add links to plot_document_clustering example#26951

Merged
adrinjalali merged 4 commits intoscikit-learn:mainfrom
Tialo:docs/add-plot-document-clusteting-example-links
Apr 26, 2024
Merged

DOC Add links to plot_document_clustering example#26951
adrinjalali merged 4 commits intoscikit-learn:mainfrom
Tialo:docs/add-plot-document-clusteting-example-links

Conversation

@Tialo
Copy link
Copy Markdown
Contributor

@Tialo Tialo commented Jul 31, 2023

Reference Issues/PRs

This adds links to text/plot_document_clustering.py examples as mentioned in #26927

What does this implement/fix? Explain your changes.

This PR adds links to text/plot_document_clustering.py example file to classes:

  1. TfidfVectorizer
  2. HashingVectorizer

Any other comments?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 31, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 9d2456a. Link to the linter CI: here


The hash function employed is the signed 32-bit version of Murmurhash3.

For an example of document clustering and comparision with ``TfidfVectorizer``,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For an example of document clustering and comparision with ``TfidfVectorizer``,
For an example of document clustering and comparision with :class:`~sklearn.feature_extraction.text.TfidfVectorizer`,

Equivalent to :class:`CountVectorizer` followed by
:class:`TfidfTransformer`.

For an example of document clustering and comparision with ``HashingVectorizer``,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above, with a link to the class.

Copy link
Copy Markdown
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marenwestermann marenwestermann added the Waiting for Second Reviewer First reviewer is done, need a second one! label Jan 5, 2024
@ArturoAmorQ
Copy link
Copy Markdown
Member

Hi @Tialo are you still working in this PR? Can you please solve the conflicts?

@Tialo
Copy link
Copy Markdown
Contributor Author

Tialo commented Apr 25, 2024

@ArturoAmorQ Sure, done

@adrinjalali adrinjalali merged commit e2f91c9 into scikit-learn:main Apr 26, 2024
@Tialo Tialo deleted the docs/add-plot-document-clusteting-example-links branch April 27, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants