Add special case handling for default engine#25549
Add special case handling for default engine#25549ogrisel merged 3 commits intoscikit-learn:feature/engine-apifrom
Conversation
|
I think we can give a prefix to this PR. I think What do you think, Tim? 🙂 |
|
I think MAINT is more for non functional code changes (release, style reformatting or another code reorg that does not change the user-facing behavior of the code base). Here is more like a FIX to not raise an exception in a context where it should not have been raised in the first place. There is also ENH for code behavior improvement for functional changes that improve the behavior for something that was not really considered as a bug but more like a limitation of the previous version of the code. |
ogrisel
left a comment
There was a problem hiding this comment.
LGTM, this is a net improvement. There are still other test failures but they seem unrelated to the focus of this PR, so let's fix them in follow-up sub PRs to the feature branch.
This fixes the problem that if you did not configure a special engine provider, then you could not keep using the estimator. The logic needed an exception for the default engine.
This PR targets the "plugin engine" feature branch.
@fcharras @jjerphan @ogrisel