MAINT Parameters validation for sklearn.cluster.dbscan#24866
Closed
vinayak-mehta wants to merge 1 commit intoscikit-learn:mainfrom
Closed
MAINT Parameters validation for sklearn.cluster.dbscan#24866vinayak-mehta wants to merge 1 commit intoscikit-learn:mainfrom
vinayak-mehta wants to merge 1 commit intoscikit-learn:mainfrom
Conversation
Contributor
Author
|
Can the |
Contributor
Author
|
Talked with @glemaitre offline, this function doesn't need parameter validation because it's already happening inside the class. |
Member
|
@vinayak-mehta I propose reopening this PR to add a note to inform the users that no parameter validation is done. In the "Notes" section we can add the following: Notes
-----
Note that the input parameters will not be validated, to optimize execution time.
If you wish to validate the parameters, use the :class:`DBSCAN` instead.
It will validate the input parameters when calling the method :term:`fit`. |
Member
|
@glemaitre the function calls the class, which validates input, therefore it's not the case that |
Member
|
True. I am confused. We are doing both ways function calling estimator and estimator calling function. So fine do keep as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #24862
What does this implement/fix? Explain your changes.
This PR adds parameter validation for
sklearn.cluster.dbscanAny other comments?