FEA implement max precision@recall K / recall@precision K#24671
Closed
Kshitij68 wants to merge 4 commits intoscikit-learn:mainfrom
Closed
FEA implement max precision@recall K / recall@precision K#24671Kshitij68 wants to merge 4 commits intoscikit-learn:mainfrom
Kshitij68 wants to merge 4 commits intoscikit-learn:mainfrom
Conversation
Kshitij68
commented
Oct 15, 2022
5e7a204 to
d61dd08
Compare
d61dd08 to
4fdcc68
Compare
Member
|
@Kshitij68 Thanks for working on this feature. Please note the discussion for inclusion in the issue #20266. |
Contributor
Author
Yes, I am following the issue. I'd still keep this PR open until a decision has been agreed upon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This PR fixes #20266
A similar PR #20877 for this was opened long time back, but currently exists in stalled state.
Refering #21718 so this PR is also visible to people following that thread
What does this implement/fix? Explain your changes.
This PR adds two new metrics
max_precision_at_recall_k&max_recall_at_precision_k.Any other comments?
There were several comments under previous PR by @glemaitre . I've been able to resolve most of them, but I would like some clarifications about two points:-
precision_recall_fscore_supportprecision_scorerecall_scoremax_precision_at_recall_kmax_recall_at_precision_kprecision_recall_curve