Skip to content

DOC Ensures that utils.extmath.density passes numpydoc validation#24516

Merged
jeremiedbb merged 3 commits intoscikit-learn:mainfrom
lumtv:docstrings_extmath_density
Sep 26, 2022
Merged

DOC Ensures that utils.extmath.density passes numpydoc validation#24516
jeremiedbb merged 3 commits intoscikit-learn:mainfrom
lumtv:docstrings_extmath_density

Conversation

@lumtv
Copy link
Copy Markdown
Contributor

@lumtv lumtv commented Sep 26, 2022

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

Adds **kwargs documentation.

Any other comments?

Not sure why kwargs is not used in function but is included as a parameter

Copy link
Copy Markdown
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Lucmtv. Actually **kwargs is not used.

lumtv and others added 2 commits September 26, 2022 17:38
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Copy link
Copy Markdown
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Lucmtv

@jeremiedbb jeremiedbb merged commit fa46434 into scikit-learn:main Sep 26, 2022
@lumtv lumtv deleted the docstrings_extmath_density branch September 26, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants