DOC Ensures that sparsefuncs.count_nonzero passes numpydoc validation#24447
Merged
jeremiedbb merged 3 commits intoscikit-learn:mainfrom Sep 16, 2022
michaelmccutchen:doc_fix_count_nonzero
Merged
DOC Ensures that sparsefuncs.count_nonzero passes numpydoc validation#24447jeremiedbb merged 3 commits intoscikit-learn:mainfrom michaelmccutchen:doc_fix_count_nonzero
jeremiedbb merged 3 commits intoscikit-learn:mainfrom
michaelmccutchen:doc_fix_count_nonzero
Conversation
jeremiedbb
reviewed
Sep 16, 2022
jeremiedbb
reviewed
Sep 16, 2022
Member
jeremiedbb
left a comment
There was a problem hiding this comment.
Thanks for the PR @b0rxington. LGTM.
(I just fixed the return statement to follow our conventions)
jeremiedbb
approved these changes
Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #21350
What does this implement/fix? Explain your changes.
Edited docstring for utils.sparsefuncs.count_nonzero such that it passes numpydoc validation
Any other comments?
N/A