Custom vocabulary checks for CountVectorizer #2357
Closed
alemagnani wants to merge 3 commits intoscikit-learn:masterfrom
Closed
Custom vocabulary checks for CountVectorizer #2357alemagnani wants to merge 3 commits intoscikit-learn:masterfrom
alemagnani wants to merge 3 commits intoscikit-learn:masterfrom
Conversation
fix bug in matrix creation for CountVectorizer
* added test for custom vocab to check fauly vocabs
sklearn/feature_extraction/text.py
Outdated
Contributor
Author
There was a problem hiding this comment.
i am not familiar with six.itervalues what is the difference?
Member
There was a problem hiding this comment.
It ensures a list is not materialised in either Py2 or 3.
Member
|
Looks good. Perhaps specify in the docstring that |
* used six.itervalues
Member
|
Thanks for the report and the fix, @alemagnani |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added check for repeating indices and gaps in custom vocabulary for CountVectorizer
added test with wrong custom vocabs
this commit fixes #2353