[MRG] DOC: fix metrics documentation format#2306
Closed
jakevdp wants to merge 1 commit intoscikit-learn:masterfrom
Closed
[MRG] DOC: fix metrics documentation format#2306jakevdp wants to merge 1 commit intoscikit-learn:masterfrom
jakevdp wants to merge 1 commit intoscikit-learn:masterfrom
Conversation
Member
Author
|
ping @GaelVaroquaux -- no code changes here; this should make it into the release if possible! |
Member
|
Should be possible. Please tag it as 0.14rc milestones, and I'll merge it tonight. ----- Original message -----
|
Member
|
@jakevdp I think you accidentally added a C file: sklearn/neighbors/dist_metrics.c |
Member
Author
|
The C file is built from the pyx file; without regenerating it, the doc change doesn't make it into the website build. |
Member
|
Hey Jake, I am too tired for merging that. I'll reschedule it to 0.14 release. |
Member
|
This looks good to me. Can you please rebase ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small sphinx formatting fix