DOC Ensures that fetch_20newsgroups passes numpydoc validation#22329
Merged
glemaitre merged 2 commits intoscikit-learn:mainfrom Jan 31, 2022
Merged
DOC Ensures that fetch_20newsgroups passes numpydoc validation#22329glemaitre merged 2 commits intoscikit-learn:mainfrom
glemaitre merged 2 commits intoscikit-learn:mainfrom
Conversation
Contributor
Author
|
@thomasjpfan does this PR needs any fixes, since it is not merged yet. |
glemaitre
reviewed
Jan 31, 2022
| A tuple of two ndarrays. The first contains a 2D array of shape | ||
| (n_samples, n_classes) with each row representing one sample and each | ||
| column representing the features. The second array of shape | ||
| (n_samples,) contains the target samples. |
Member
There was a problem hiding this comment.
I made a small push to be sure that there are no trailing spaces and that we respect the PEP8/black convention (meaning no more than 88 characters per line).
You can check the commit that I just pushed. It should be enough for this PR. I will merge once the CI is green..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #21350
What does this implement/fix? Explain your changes.
This PR fixes the following error that was appearing for numpydoc validation for sklearn.datasets._twenty_newsgroups.fetch_20newsgroups
-RT03: Return value has no description
Any other comments?
Thanks