DOC Ensures that graphical_lasso passes numpydoc validation#22326
Merged
thomasjpfan merged 3 commits intoscikit-learn:mainfrom Jan 29, 2022
Diwakar-Gupta:main
Merged
DOC Ensures that graphical_lasso passes numpydoc validation#22326thomasjpfan merged 3 commits intoscikit-learn:mainfrom Diwakar-Gupta:main
thomasjpfan merged 3 commits intoscikit-learn:mainfrom
Diwakar-Gupta:main
Conversation
added 2 commits
January 29, 2022 03:05
merged with upstream/main
thomasjpfan
approved these changes
Jan 29, 2022
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thanks for the PR @Diwakar-Gupta ! LGTM
Contributor
Author
|
Thank u, and it was fun to fix this. |
Contributor
Author
|
@thomasjpfan I want your review on this, I found that in Naive Bayes algo there is no implementation for handling categorical and numerical features both, insteed we have multinomial for categorical only and Gaussian when all the features are gaussian distribution. So I thought to implement a class that can handle both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #21350
What does this implement/fix? Explain your changes.
Wrote missing description of GraphicalLasso and GraphicalLassoCV in sklearn.covariance.graphical_lasso.
Any other comments?
Description of GraphicalLasso is wrong in sklearn.covariance.GraphicalLassoCV.
Have already raised issue at Addresses #22325