DOC Ensures that sklearn.datasets._base.load_breast_cancer passes numpydoc validation#22266
Closed
DennisOsei wants to merge 2 commits intoscikit-learn:mainfrom
Closed
DOC Ensures that sklearn.datasets._base.load_breast_cancer passes numpydoc validation#22266DennisOsei wants to merge 2 commits intoscikit-learn:mainfrom
DennisOsei wants to merge 2 commits intoscikit-learn:mainfrom
Conversation
ArturoAmorQ
reviewed
Jan 27, 2022
Comment on lines
+705
to
+707
| A tuple of two ndarrays. The first contains a 2D array of shape (569, 30) | ||
| with each row representing one sample and each column representing the features. | ||
| The second array of shape (569,) contains the target samples. |
Member
There was a problem hiding this comment.
Suggested change
| A tuple of two ndarrays. The first contains a 2D array of shape (569, 30) | |
| with each row representing one sample and each column representing the features. | |
| The second array of shape (569,) contains the target samples. | |
| A tuple of two ndarrays by default. The first contains a 2D ndarray of | |
| shape (569, 30) with each row representing one sample and each column | |
| representing the features. The second ndarray of shape (569,) contains | |
| the target samples. If `as_frame=True`, both arrays are pandas objects. |
Maybe being more explicit here could make the description easier to understand.
Also try to follow the PEP 8 convention, i.e. limit all lines to a maximum of 79 characters and avoid blank spaces at the end of each line.
Member
There was a problem hiding this comment.
I'm still getting the "return value has no description" error.
The following lines of code are creating the error:
The copy of UCI ML Breast Cancer Wisconsin (Diagnostic) dataset is
downloaded from:
https://goo.gl/U2Uwz2
I propose moving them to the description in the header below the table.
Contributor
Author
There was a problem hiding this comment.
Thanks for the help @ArturoAmorQ it worked.
Member
|
@DennisOsei Additionally to @ArturoAmorQ comment, could you solve the conflict by merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #21350
What does this implement/fix? Explain your changes.
A tuple of two ndarrays. The first contains a 2D array of shape (569, 30)
with each row representing one sample and each column representing the features.
The second array of shape (569,) contains the target samples.
Any other comments?
I'm still getting the "return value has no description" error.