Skip to content

DOC Ensures that compute_optics_graph passes numpydoc validation#22205

Merged
jjerphan merged 2 commits intoscikit-learn:mainfrom
ayanbag:docstring_fix
Jan 21, 2022
Merged

DOC Ensures that compute_optics_graph passes numpydoc validation#22205
jjerphan merged 2 commits intoscikit-learn:mainfrom
ayanbag:docstring_fix

Conversation

@ayanbag
Copy link
Copy Markdown
Contributor

@ayanbag ayanbag commented Jan 13, 2022

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

Removed an unnecessary period after parameter "X" type and added a missing period after parameter "X" description.

Any other comments?

Copy link
Copy Markdown
Member

@jmloyola jmloyola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ayanbag 🤓

I left one suggestion. It is something that was already in the code-base, but since we're fixing the docs, it would be great to do it now ^^.

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 once @jmloyola's suggestion is accepted.

Co-authored-by: Juan Martin Loyola <jmloyola@outlook.com>
Copy link
Copy Markdown
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jjerphan jjerphan merged commit 3db677f into scikit-learn:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants