DOC Ensures that sklearn.metrics.pairwise.paired_cosine_distances passes numpydoc validation#22141
Merged
jjerphan merged 11 commits intoscikit-learn:mainfrom Jan 18, 2022
Merged
Conversation
Brought into numpydoc compliance
Now matches de-facto pairwise.py standard
Fixed docs by removing reference to a default arg for Y
…/Micky774/scikit-learn into numpydoc_paired_cosine_distances
Changed num_features_(X/Y) to just num_features
…/Micky774/scikit-learn into numpydoc_paired_cosine_distances
thomasjpfan
reviewed
Jan 11, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
approved these changes
Jan 11, 2022
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thanks for the update LGTM!
jjerphan
approved these changes
Jan 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #21350
What does this implement/fix? Explain your changes.
Brings
sklearn.metrics.pairwise.paired_cosine_distancesinto numpydoc complianceAny other comments?
N/A