Skip to content

DOC Ensures spectral_clustering clustering numpydoc validation#22025

Merged
glemaitre merged 5 commits intoscikit-learn:mainfrom
moonkyung-kang:sklearn.cluster._spectral.spectral_clustering
Jan 28, 2022
Merged

DOC Ensures spectral_clustering clustering numpydoc validation#22025
glemaitre merged 5 commits intoscikit-learn:mainfrom
moonkyung-kang:sklearn.cluster._spectral.spectral_clustering

Conversation

@moonkyung-kang
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

#21350

What does this implement/fix? Explain your changes.

End the sentence with a period.
Sections are in the wrong order. Correct order is: Parameters, Returns, Notes, References

Any other comments?

@glemaitre
Copy link
Copy Markdown
Member

I will try to merge main into your branch but I was under the impression that we already merge such fixes for these functions.

Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is updating the spectral_clustering function so we are fine. Let's wait for the CIs to pass.

@glemaitre glemaitre merged commit 4a4d135 into scikit-learn:main Jan 28, 2022
@thomasjpfan thomasjpfan changed the title DOC Ensures sklearn.cluster. spectral.spectral clustering numpydoc validation DOC Ensures spectral_clustering clustering numpydoc validation Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants