MNT Accelerate plot_model_complexity_influence.py modifying the SGDClassifier parameters#21963
Merged
glemaitre merged 3 commits intoscikit-learn:mainfrom Jan 18, 2022
Conversation
41 tasks
glemaitre
approved these changes
Jan 18, 2022
Member
glemaitre
left a comment
There was a problem hiding this comment.
LGTM after checking the plots. I think that we a x2 here. This should be enough to merge it.
Member
|
Thanks @drskd Merging. |
Contributor
Author
|
Thanks for the review @glemaitre ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#21598
What does this implement/fix? Explain your changes.
It changes the parameters of the SGDClassifier in order to accelerate the run time of plot_model_complexity_influence.py. This will help to speed up the CI as it takes part in it.
The major part of the time is spent in _plain_sgd. By changing two parameters (tol and n_iter_no_change), the time spent in this function is reduced and the graph used to illustrate the notions involved in the example stays relevant.
On my computer, the time for this example dropped from 13 to 6.5 seconds.
Any other comments?