FIX Do not reset for non-fit in multiclass#20205
FIX Do not reset for non-fit in multiclass#20205glemaitre merged 5 commits intoscikit-learn:mainfrom
Conversation
jeremiedbb
left a comment
There was a problem hiding this comment.
My bad, I changed the validation scheme twice and copy pasted too quickly for the last version :/
|
Actually it seems to break something. Let's validate properly: |
This can create a new numpy array when X is a list and Thinking through the test such as |
|
On a related note, I have been seeing the CI failing which is related related to the issue when the inner estimator is not validating. In that case |
ogrisel
left a comment
There was a problem hiding this comment.
LGTM but don't we need a dedicated non-regression test for this?
ogrisel
left a comment
There was a problem hiding this comment.
I approved this PR without realizing that there were newly introduced broken tests :(
|
Thanks @thomasjpfan |
Follow up to #20193
CC @jeremiedbb @ogrisel @glemaitre