Skip to content

ENH Checks n_features_in_ after fitting in random_projection#19541

Merged
ogrisel merged 1 commit intoscikit-learn:mainfrom
thomasjpfan:check_n_features_in_random_projection
Feb 25, 2021
Merged

ENH Checks n_features_in_ after fitting in random_projection#19541
ogrisel merged 1 commit intoscikit-learn:mainfrom
thomasjpfan:check_n_features_in_random_projection

Conversation

@thomasjpfan
Copy link
Copy Markdown
Member

Reference Issues/PRs

Related to #19333

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ogrisel ogrisel merged commit 12db86e into scikit-learn:main Feb 25, 2021
@ogrisel
Copy link
Copy Markdown
Member

ogrisel commented Feb 25, 2021

Merged to move forward. But I think it would be nicer to address the documentation in the same PR for future related PRs.

@thomasjpfan
Copy link
Copy Markdown
Member Author

Merged to move forward. But I think it would be nicer to address the documentation in the same PR for future related PRs.

Okay that makes sense.

@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants