ENH Checks n_features_in_ after fitting in mixture#19540
Merged
jeremiedbb merged 4 commits intoscikit-learn:mainfrom Mar 23, 2021
Merged
ENH Checks n_features_in_ after fitting in mixture#19540jeremiedbb merged 4 commits intoscikit-learn:mainfrom
jeremiedbb merged 4 commits intoscikit-learn:mainfrom
Conversation
47 tasks
jeremiedbb
approved these changes
Mar 18, 2021
Member
jeremiedbb
left a comment
There was a problem hiding this comment.
LGTM as well. Shouldn't the doc of n_features_in_ be done in this PR for (Bayesian)GaussianMixture ?
Member
Author
|
Added the attribute to the docstring. Note that the |
Member
|
Thanks @thomasjpfan ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #19333
What does this implement/fix? Explain your changes.
Checks
n_features_in_after fitting in mixture module.Any other comments?
I also moved the self.component validation to
fit, since this is the only time it is called.