Skip to content

TST replace assert_raise with pytest.raises in test_base.py#19500

Merged
rth merged 1 commit intoscikit-learn:mainfrom
azihna:fix_base_pytest_assert
Feb 22, 2021
Merged

TST replace assert_raise with pytest.raises in test_base.py#19500
rth merged 1 commit intoscikit-learn:mainfrom
azihna:fix_base_pytest_assert

Conversation

@azihna
Copy link
Copy Markdown
Contributor

@azihna azihna commented Feb 19, 2021

Reference Issues/PRs

Reference #14216

What does this implement/fix? Explain your changes.

Changed the assert_raises in tests/test_base.py to pytest.raises(...):

Any other comments?

#DataUmbrella
cc: @reshamas
@Mariam-ke

Copy link
Copy Markdown
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks @azihna

Copy link
Copy Markdown
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rth rth merged commit 1000d0a into scikit-learn:main Feb 22, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants