TST Remove use of assert raise message from test validation#19432
Closed
cycks wants to merge 2 commits intoscikit-learn:mainfrom
Closed
TST Remove use of assert raise message from test validation#19432cycks wants to merge 2 commits intoscikit-learn:mainfrom
cycks wants to merge 2 commits intoscikit-learn:mainfrom
Conversation
…/test_validation.py
Member
|
The linting is failing: https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=26484&view=logs&j=32e2e1bb-a28f-5b18-6cfc-3f01273f5609&t=fc67071d-c3d4-58b8-d38e-cafc0d3c731a It seems that you have issue with indentation. Be aware that you did not have to create a PR but just make the changes in the same branch that you created when submitting #19381 and just push this branch. I will close this PR to not have duplicated work. Could you modify the original PR: #19381 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
References #14216
What does this implement/fix? Explain your changes.
@glemaitre replace assert_raise_message by pytest.raise in model_selection/tests/test_validation.py
Any other comments?
No other comments
#DataUmbrella sprint