TST replace assert_raise_* by pytest.raises in ensemble module#19399
Merged
rth merged 8 commits intoscikit-learn:mainfrom Feb 11, 2021
Merged
TST replace assert_raise_* by pytest.raises in ensemble module#19399rth merged 8 commits intoscikit-learn:mainfrom
rth merged 8 commits intoscikit-learn:mainfrom
Conversation
Co-authored-by: feras-oughali <oughali.feras@gmail.com>
…nto fix_assert_raises
Contributor
|
#DataUmbrella sprint |
…nto fix_assert_raises
Co-authored-by: feras-oughali <oughali.feras@gmail.com>
Co-authored-by: feras-oughali <oughali.feras@gmail.com>
Co-authored-by: feras-oughali <oughali.feras@gmail.com>
glemaitre
reviewed
Feb 11, 2021
Member
glemaitre
left a comment
There was a problem hiding this comment.
LGTM. I solve the conflict with the main branch after having merge some other PRs.
@jeremiedbb Do you want to have a look at this one.
glemaitre
approved these changes
Feb 11, 2021
rth
approved these changes
Feb 11, 2021
Member
rth
left a comment
There was a problem hiding this comment.
Thank you @halsawadi and @feras-oughali!
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: @feras-oughali
Reference Issues/PRs
This PR is related to issue #14216
What does this implement/fix? Explain your changes.
Change assert_raises and assert_raises_regex to :
with pytest.raises(.....)
This is a part of Data Umbrella's sprint that was held in February 2021.