RFC Renames reset to in_fit in _validate_data#18001
Closed
thomasjpfan wants to merge 1 commit intoscikit-learn:masterfrom
Closed
RFC Renames reset to in_fit in _validate_data#18001thomasjpfan wants to merge 1 commit intoscikit-learn:masterfrom
thomasjpfan wants to merge 1 commit intoscikit-learn:masterfrom
Conversation
Member
|
I think the name was discussed quite a bit in the SLEP PR and in the implementation PR. We need to reset the n_features_in attribute when:
|
Member
Author
|
For the partial fit it makes sense. The semantics of calling Closing. I can not think of a nicer way handle this. |
Member
I agree. Maybe we should consider having a second method to use in predict, transform, etc? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think
in_fitorfittinghas clearer semantics thanresetwhen thinking of_validate_data.The small code change is to check y only when fitting:
CC @NicolasHug