Skip to content

[NOMRG] Check if pickle error issues on master#17719

Closed
alfaro96 wants to merge 4 commits intoscikit-learn:masterfrom
alfaro96:check_pickle_error
Closed

[NOMRG] Check if pickle error issues on master#17719
alfaro96 wants to merge 4 commits intoscikit-learn:masterfrom
alfaro96:check_pickle_error

Conversation

@alfaro96
Copy link
Copy Markdown
Member

Let us see if the PicklingError issues on master @adrinjalali.

@alfaro96 alfaro96 changed the title [NOMRG] Check if pickle error issues in master [scipy-dev] [NOMRG] Check if pickle error issues in master Jun 25, 2020
@adrinjalali
Copy link
Copy Markdown
Member

Complaining about np.bool? I thought we fixed that

@alfaro96
Copy link
Copy Markdown
Member Author

alfaro96 commented Jun 25, 2020

Complaining about np.bool? I thought we fixed that

There is still one missing in:

from numpy import bool as np_bool

that was fixed in #17707.

This makes the tests not to run.

Fix temporally in this PR and trigger the build again?

@alfaro96 alfaro96 changed the title [NOMRG] Check if pickle error issues in master [NOMRG] Check if pickle error issues om master Jun 25, 2020
@alfaro96 alfaro96 changed the title [NOMRG] Check if pickle error issues om master [NOMRG] Check if pickle error issues on master Jun 25, 2020
@alfaro96
Copy link
Copy Markdown
Member Author

@adrinjalali I think I need to apply the changes in PR #17707 (or, at least, most of them) before we can actually check if the PicklingError appears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants