Skip to content

MRG FIX for iid weighting in grid-search#1731

Closed
amueller wants to merge 2 commits intoscikit-learn:masterfrom
amueller:gridsearch_n_samples_test
Closed

MRG FIX for iid weighting in grid-search#1731
amueller wants to merge 2 commits intoscikit-learn:masterfrom
amueller:gridsearch_n_samples_test

Conversation

@amueller
Copy link
Copy Markdown
Member

@amueller amueller commented Mar 3, 2013

This is a fix for the iid weighting in GridSearchCV. It could be that I screwed this up before, but didn't notice as there was no test.

@amueller amueller mentioned this pull request Mar 3, 2013
Closed
ogrisel
ogrisel reviewed Mar 3, 2013
View reviewed changes
doc/tutorial/statistical_inference/model_selection.rst Outdated
Copy link
Copy Markdown
Member

@ogrisel ogrisel Mar 3, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will get rounding errors: computers have finite precisions. We cannot expect all platform to round stuff exactly the same way at the 17th place, can we? I think we should expect:

0.9889999999999...             # doctest: +ELLIPSIS

Copy link
Copy Markdown
Member Author

@amueller amueller Mar 3, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then I'll change all the tests in the file...

Copy link
Copy Markdown
Member Author

@amueller amueller Mar 3, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other numbers in the file seemed not to be periodic, so I kept them.

@ogrisel
Copy link
Copy Markdown
Member

ogrisel commented Mar 3, 2013

That looks good. Maybe @agramfort can you check this fix? I think you were the original author of the iid flag.

@amueller
Copy link
Copy Markdown
Member Author

amueller commented Mar 5, 2013

rebased to fix merging trouble

jaquesgrobler
jaquesgrobler reviewed Mar 14, 2013
View reviewed changes
sklearn/tests/test_grid_search.py
Copy link
Copy Markdown
Member

@jaquesgrobler jaquesgrobler Mar 14, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo on=one

@jaquesgrobler
Copy link
Copy Markdown
Member

jaquesgrobler commented Mar 14, 2013

This all looks well to me and the test is good too. it's ready for merge, right? :)

@amueller
Copy link
Copy Markdown
Member Author

amueller commented Mar 15, 2013

Yes, should be good. I agree with @ogrisel that it would be nice to have @agramfort's 👍 but I'm not sure he is available / has time.

@agramfort
Copy link
Copy Markdown
Member

agramfort commented Mar 15, 2013

merged by rebase after fixing the typo.

@agramfort agramfort closed this Mar 15, 2013
@amueller
Copy link
Copy Markdown
Member Author

amueller commented Mar 15, 2013

Thanks :)

@amueller amueller deleted the gridsearch_n_samples_test branch March 15, 2013 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amueller @ogrisel @jaquesgrobler @agramfort