_xfail_tests -> _xfail_checks & revert changes to check_estimator#17175
Closed
rth wants to merge 3 commits intoscikit-learn:masterfrom
Closed
_xfail_tests -> _xfail_checks & revert changes to check_estimator#17175rth wants to merge 3 commits intoscikit-learn:masterfrom
rth wants to merge 3 commits intoscikit-learn:masterfrom
Conversation
rth
commented
May 10, 2020
| # skip tests marked as a known failure and raise a warning | ||
| msg = xfail_checks[check_name] | ||
| warnings.warn(f'Skipping {check_name}: {msg}', SkipTestWarning) | ||
| continue |
Member
Author
There was a problem hiding this comment.
All changes to check_estimator revert the modifications in #16507 since they are no longer relevant.
| def _more_tags(self): | ||
| return { | ||
| '_xfail_test': { | ||
| '_xfail_checks': { |
Member
Author
There was a problem hiding this comment.
The name of the tag was changed on master
Member
Author
|
In the end there does look like some changes to |
Member
|
ping me on the new one please ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CI and some outdated parts from #16507 merged by accident.
Reverts
check_estimatorto its previous version on master, since the xfail estimators tags were better addressed in earlier PRs.