fixed stylistic changes for _dbscan.py based on documentation guidelines #16163
Closed
sophsoph321 wants to merge 3 commits intoscikit-learn:masterfrom
sophsoph321:sophiezhao
Closed
fixed stylistic changes for _dbscan.py based on documentation guidelines #16163sophsoph321 wants to merge 3 commits intoscikit-learn:masterfrom sophsoph321:sophiezhao
sophsoph321 wants to merge 3 commits intoscikit-learn:masterfrom
sophsoph321:sophiezhao
Conversation
…hm. Also update default values of sample_weight and p
NicolasHug
approved these changes
Jan 21, 2020
Member
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks @sophsoph321 , I think the suggestion below should fix the line-too-long issue. LGTM otherwise
Member
|
You can also check the linting locally (refer to step 5 of https://scikit-learn.org/stable/developers/contributing.html#pull-request-checklist) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed documentation for _dbscan.py based on documentation guidelines https://scikit-learn.org/stable/developers/contributing.html#guidelines-for-writing-documentation