Fix: test_ard_accuracy_on_easy_problem fails on CPU with AVX-512#16102
Closed
rushabh-v wants to merge 1 commit intoscikit-learn:masterfrom
Closed
Fix: test_ard_accuracy_on_easy_problem fails on CPU with AVX-512#16102rushabh-v wants to merge 1 commit intoscikit-learn:masterfrom
rushabh-v wants to merge 1 commit intoscikit-learn:masterfrom
Conversation
Contributor
Author
|
Can you merge this, please? @thomasjpfan |
Member
|
Does increasing the number of iterations result in AVX-512 finding the correct solution? |
Member
|
I also have mixed feelings about this. We can improve tolerance as a fix, but it would also be good to understand why the tolerance is so much worse in this case than the expected 1E-4 (and if there is a way to fix it, at least indeed by increasing the number of iterations). |
Member
|
Do we have an architecture where we can test it? |
Closed
Contributor
|
This PR will probably close #15186 too. |
Member
|
Unfortunately, there is a deeper instability issue that needs to be addressed (please see #15186 (comment)) We can increase the tolerance of the test to make the CIs happy, but we'd be basically just sweeping it under the rug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #16097